Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_AUTHOR_152: Cannot create legacy library unless you are global staff or a library already exists for that org #433

Open
ormsbee opened this issue Dec 9, 2024 · 6 comments
Assignees
Labels
release testing Affects the upcoming release (attention needed) sumac
Milestone

Comments

@ormsbee
Copy link

ormsbee commented Dec 9, 2024

Release

Sumac

Expected behavior

A user who is not global staff, but is a course creator for all orgs should be able to create a new Content Library for any org.

Actual behavior

A non-global-staff course creator can only create a library for an org that already has a library.

Steps to reproduce

(This assumes that you do not have any legacy libraries to start out with.)

  1. Create a new user and use the course_creators Django admin to make them a course creator for all orgs.
  2. Click on the legacy libraries tab in studio.
  3. Click the button to create a New Library.

At this point, it will bring up the form for creating a new library, but there will be no selectable org (and no way to enter the name of an org) unless you are global staff.

Next, use a global staff account to create a legacy library for a particular org. If you then go back to Studio with your course creator account, you should see that org (and only that org) as selectable.

Additional information

No response

@ormsbee ormsbee added release testing Affects the upcoming release (attention needed) needs triage labels Dec 9, 2024
@ormsbee
Copy link
Author

ormsbee commented Dec 9, 2024

@jmakowski1123: Please assess whether this is a release blocker.

@mariajgrimaldi mariajgrimaldi self-assigned this Dec 9, 2024
@ormsbee
Copy link
Author

ormsbee commented Dec 9, 2024

Note this is possibly related to #428, the fix for which had not yet been deployed to the sandbox when I did my testing. I'll test again once the Sumac test sandbox is rebuilt.

@mariajgrimaldi
Copy link
Member

@ormsbee: I tested locally with and without the fix, and it breaks without the changes. So it's definitely related.

@mariajgrimaldi
Copy link
Member

@ormsbee: the changes are available in the sandbox! You can retest now :)

@ormsbee
Copy link
Author

ormsbee commented Dec 10, 2024

I still see a variant of this problem happening. Though it's weird–creating a course also makes it so that the org shows up. I'll keep this open, but @jmakowski1123 confirms that this is not a release blocker.

@mariajgrimaldi
Copy link
Member

Thanks for testing! @ormsbee: I don't quite get what you mean by creating a course also makes it so that the org shows up, can you elaborate?

@mariajgrimaldi mariajgrimaldi added this to the Sumac.2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed) sumac
Projects
Status: No status
Development

No branches or pull requests

2 participants