Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_LEARNER_50: Missing search box in the learner dashboard #431

Open
angonz opened this issue Dec 3, 2024 · 12 comments
Open
Assignees
Labels
release testing Affects the upcoming release (attention needed) sumac
Milestone

Comments

@angonz
Copy link

angonz commented Dec 3, 2024

Release

Sumac

Expected behavior

There should be a search box in the learner dashboard.

Actual behavior

There is no search box in the learner dashboard.

Steps to reproduce

Go to the LMS, learner dashboard.
image

Additional information

No response

@angonz angonz added release testing Affects the upcoming release (attention needed) needs triage labels Dec 3, 2024
@magajh
Copy link

magajh commented Dec 5, 2024

Thanks for the report, I've confirmed this issue is occurring for both the community remote environment and the sandbox for Sumac

@magajh
Copy link

magajh commented Dec 5, 2024

I can't seem to find anything related to a search box in the Learner Dashboard MFE. I've opened an issue in the repository to confirm with the maintainers if we should expect a search box there: openedx/frontend-app-learner-dashboard#521

@crathbun428, could we please review this test (TC_LEARNER_50) to ensure it’s still valid for the new Learner Dashboard (MFE)?

@crathbun428
Copy link

@magajh and @angonz - I went back and looked at the learner dashboard in Redwood, and it looks the same as it does for Sumac.

Yeah this is an old test that needs to be reworked - thank you for pointing this out. There is a search bar on both, but it only appears if you have permissions to masquerade (or view content as X user). See the screenshots of Redwood and Sumac below.
Screenshot 2024-12-05 at 9 15 25 AM
Screenshot 2024-12-05 at 9 15 16 AM

If you're logged in as an active learner, you wouldn't see it. I wouldn't consider this a test failure knowing this - I can update the test now.

@mariajgrimaldi
Copy link
Member

Thank you, @crathbun428 @magajh! I'll be closing this since it's a non-issue.

@angonz
Copy link
Author

angonz commented Dec 5, 2024

I think that the test refers to searching between the student's courses for course content, not the user selector for masquerading. This feature was available before the learner-dashboard MFE and AFAIK there is no DEPR ticket for it.

@angonz
Copy link
Author

angonz commented Dec 5, 2024

I'm asking to reopen for a clarification on this point.

@angonz angonz reopened this Dec 5, 2024
@crathbun428
Copy link

@angonz - Thank you for this context - let me see if I can tap someone who has more experience with this particular page to weigh in.

@crathbun428
Copy link

@angonz - I checked in with an FE engineer here and he couldn't recall there being a search bar on this page either. A brief look at the repo turned up nothing as well. Could you provide details and screenshots of an environment where this search bar exists? Trying to figure out where this search bar was lost (if possible) to help get to the bottom of this.

cc: @brian-smith-tcril

@magajh
Copy link

magajh commented Dec 6, 2024

@crathbun428 In case it's helpful to have this information, the old learner dashboard did include a search bar for courses.

legacy-learner-dashboard

There's even an old ticket for this same test related to the legacy dashboard during the Quince release: #321

What I initially thought is that the Learner Dashboard MFE doesn’t actually have a search bar, and this test was likely never removed when the MFE became the default dashboard. In fact, the test sheet shows that the test also failed in Redwood.

I opened this issue hoping someone could help confirm this, but I haven’t received any response yet: openedx/frontend-app-learner-dashboard#521

@crathbun428
Copy link

Excellent - thank you, @magajh. It looks like the search bar was potentially just removed when this was converted to an MFE. I do think it makes sense to have one on this page.

@magajh
Copy link

magajh commented Dec 9, 2024

@crathbun428 @angonz We got a reply from the maintainers here: openedx/frontend-app-learner-dashboard#521 (comment)

I think we can go ahead and close this issue after adding a note or updating the test

@angonz
Copy link
Author

angonz commented Dec 9, 2024

I think this is something that should be discussed as part of the product agenda. We have received requests from customers to support a course search functionality. I believe it's a useful feature allowing students to look for something they remember having seen somewhere but not exactly where.

@mariajgrimaldi mariajgrimaldi added this to the Sumac.2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed) sumac
Projects
Development

No branches or pull requests

4 participants