Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_AUTHOR_50: Numerical input component generates an error with the formula shown in the usage example. #420

Open
DeimerM opened this issue Nov 19, 2024 · 6 comments
Assignees
Labels
release testing Affects the upcoming release (attention needed) sumac
Milestone

Comments

@DeimerM
Copy link

DeimerM commented Nov 19, 2024

Release

Sumac

Expected behavior

It is required that when the example formula is entered into the numerical input component, it should render without any errors.

Actual behavior

When a numeric component is added, and the formula shown in the example is entered m*c^2, an error occurs

Steps to reproduce

  1. Add a numerical input component.
  2. Enter the formula shown in the example: m*c^2.
  3. Observe the error.

Additional information

Error obtained:

Screenshot From 2024-11-14 09-48-33

Example:

Screenshot From 2024-11-14 09-48-51

@DeimerM DeimerM added needs triage release testing Affects the upcoming release (attention needed) labels Nov 19, 2024
@mariajgrimaldi mariajgrimaldi self-assigned this Dec 2, 2024
@DonatoBD DonatoBD assigned DonatoBD and unassigned mariajgrimaldi Dec 2, 2024
@mariajgrimaldi
Copy link
Member

@DonatoBD: have you had a chance to triage this? Let me know!

@pdpinch
Copy link

pdpinch commented Dec 5, 2024

I'll take a look into this, but I think the issue is that the sample problem is incomplete. If I recall correctly, the problem needs to define variables like m and c in order for the learner submission to work.

@pdpinch pdpinch self-assigned this Dec 5, 2024
@DonatoBD
Copy link

DonatoBD commented Dec 5, 2024

Hi, as @pdpinch mentioned, the answer's value should include integers, fractions, and constants. The formula works correctly in nutmeg (without mfe), but it doesn't work in redwood (with mfe enabled).

I'm not very sure about the constants, but I'm reviewing 'Completing Mathematical and Scientific Assignments' to see if it's a configuration issue with the component or an error with the constants we've had for a long time.

@DonatoBD
Copy link

DonatoBD commented Dec 5, 2024

Well, this is kinda interesting. Comparing it to nutmeg (without mfe), I could see that the olx of the "numerical input" problems adapts depending on the answer.

When we put "m*c^2" and see the olx, it's created as a "stringresponse", while if we put "10" it creates it as a "numericalresponse".

However, in the mfe of course-authoring, the template for each problem is already defined, and the numerical input only uses "numericalresponse".

For the case of defining variables, there's the advanced problem of "math expressions", which uses "formularesponse".

This makes me think that this case has been happening since the new component editors were activated with the mfe. I don't know if we should open an issue in course-authoring so that the creation of the olx for numerical input adapts the same as before, or on the contrary, pass it to the product to see if they want to stick to the premise that it only accepts integers and for everything else, use another type of component

cc @mariajgrimaldi

@pdpinch
Copy link

pdpinch commented Dec 5, 2024 via email

@mariajgrimaldi
Copy link
Member

@DonatoBD: I agree we should open the issue in the course authoring MFE and discuss what can do to move this forward there. What do you think?

@mariajgrimaldi mariajgrimaldi added this to the Sumac.2 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release testing Affects the upcoming release (attention needed) sumac
Projects
Status: No status
Development

No branches or pull requests

4 participants