-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test failure] <TC_LEARNER_REDWOOD_8>: <Only one in-course experience sidebar can be open at a time failing> #404
Comments
I made a PR openedx/frontend-app-learning#1519 |
@jciasenza: I see your PR was already merged to master. That's great news! Could you give us a hand opening a PR against open-release/sumac? master so we can include this fix in the sumac release? We'd appreciate it! |
@mariajgrimaldi, @jciasenza, @lkatsikaris - Maybe I'm reading this wrong, but the video does not show 2 sidebars being open at the same time. This test intends to make sure you can't open a LEFT and RIGHT sidebar at the same time. The left sidebar can and should be able to expand or collapse multiple sections/subsections at the same time. If that is what this bug is reporting, this is not a bug. Please confirm. |
@crathbun428: I do think that what this is reporting, and this new behavior was included in the sidebar. Should we contact the maintainers to revert it? |
If the PR that was created makes it so you can't expand 2 subsections in the left sidebar at the same time, then we should absolutely revert it. Let me know what I can do to help. |
@crathbun428: yes, you can review the new behavior in this video. Can you comment in this PR tagging @farhaanbukhsh explaining the situation? So there's a trail of the discussion. Thank you! |
@mariajgrimaldi - done |
I'll close this issue as the PR does not reflect the test case. |
why are we closing this issue? |
Because the test case is that a right sidebar (notifications, forum) and a left sidebar (navigation) cannot be open at the same time. If you open the right sidebar, the left sidebar should hide, and vice-versa. |
@angonz Understood, should we open an issue to add this test case? |
Thank you all, @farhaanbukhsh, @angonz, @crathbun428, and @lkatsikaris! This was mainly my mistake because I didn't read into this further. Farhaan already opened the PR to revert the changes in master, and since no backport was opened sumac wasn't affected. Andrés, can we clarify the test case as you did in this comment? |
Release
Sumac
Expected behavior
Only one sidebar can be opened at a time. When I expand a second sidebar while the opposite sidebar is open, the second sidebar expands while the other collapses.
Actual behavior
When I expand a second sidebar while the opposite sidebar is open, the second sidebar still open.
Steps to reproduce
Given I am a user enrolled in a course on an in-course experience page on an instance with the courseware.enable_navigation_sidebar is enabled. When I expand a second sidebar while the opposite sidebar is open, the second sidebar still open.
Screencast.from.11-06-2024.09.53.45.AM.webm
Additional information
No response
The text was updated successfully, but these errors were encountered: