Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization is failing for certain languages and certain pages #267

Closed
jswope00 opened this issue Apr 22, 2023 · 17 comments
Closed
Labels
Milestone

Comments

@jswope00
Copy link

There appears to be great coverage for the English and Spanish languages on https://palm.demo.overhang.io/

But spot-checking other languages like German and Italian I am seeing gaps where pages are not translated. For what seems like most languages outside of English and Spanish, these pages are not being translated:

  1. Profile: https://prnt.sc/z4dGtXn-O0By
  2. Account: https://prnt.sc/9s6A4RgMqbTR
  3. Popups: https://prnt.sc/ICaT5O0Q8weT
  4. Selective elements on Course homepage: https://prnt.sc/ICaT5O0Q8weT
  5. Progress Page: https://prnt.sc/Sf9VH5YEDZY3
  6. Dates: https://prnt.sc/MYIhC-JnYkHi

Happy to find more pages and languages if it is helpful, but this looks widespread and related to the MFEs to me.

@DeanJayMathew
Copy link

Let's bring this up with @ghassanmas, @sambapete, @edenhuthmacher and other leaders of the Translation Working Group for their potential insights into this issue.

@ghassanmas
Copy link
Member

ghassanmas commented May 3, 2023

As a translator of Arabic I have checked all the above mentioend repos and found the translation exists in source files, for ref

@ghassanmas
Copy link
Member

ghassanmas commented May 3, 2023

Now for other langauges we would need to check the problem:

  1. If it's not translated then we would ask translator to review/translate the strings
    1. Then we would need to wait for Jenkis jobs to sync translation on master which run usually every Mondy
    2. Lastly someone would need to backport the commit from last step to open-release/maser.palm
  2. If it's a technical issue we would need to see why the translation aren't being pulled:
    1. This has been a straight forward thing to resolve in the past, as I don't know who to reach out for, and it would also vary by the cause

@brian-smith-tcril in the following PR you have asked for context

@sambapete
Copy link

I don't seem to have any issues selecting fr_CA in the account MFE and having pages translated to fr_CA. It could be very language specific. Maybe some of the languages were the problems are occurring are not a 100% translated?

@jalondonot jalondonot added this to the Palm.1 milestone May 15, 2023
@DeanJayMathew
Copy link

DeanJayMathew commented May 17, 2023

@ghassanmas @sambapete

Which languages should we cover in testing?

English
Spanish
Arabic
French Canadian
French France

Any others you think should be part of the test plan?

@jyliugithub
Copy link

Just checked Mandarin( Chinese) , a lot has not been synced ( especially Course, Progress, Date,Discussion) . Not sure if it is because of the cut off date ( Apr) or anything else.

@ghassanmas
Copy link
Member

@jyliugithub Thank you for testing.
Checking the frontend-app-learning resource in Mandarin https://app.transifex.com/open-edx/edx-platform/language/zh_CN/, it's about 23% reviewed while 100% translated And you can only see from here it's only pulling hte reviewed strings https://github.com/openedx/frontend-app-learning/blob/master/src/i18n/messages/zh_CN.json .

@jyliugithub
Copy link

@ghassanmas I see. Thanks for letting me know. I will try to finish the reviewing of the frontend learning strings then test again. Give me a couple of days, I will update again here.

@pdpinch
Copy link

pdpinch commented Jun 14, 2023

Should the release notes include this as a "known issue"? If so please propose some text on the release notes PR at openedx/docs.openedx.org#321

@mariajgrimaldi
Copy link
Member

Hi there! Do we have an update on this issue? I also noticed there is no clear solution -- eg. translate MFEs to german or fix chinese translations. Should we add one? So we know when this is done.

@jyliugithub
Copy link

@mariajgrimaldi https://palm.demo.overhang.io/dashboard can not be accessed at the moment. Although the Chinese translation for frontend-app-learning is done, I can not check if the translation has been synced or not.

@mariajgrimaldi mariajgrimaldi modified the milestones: Palm.1, Palm.2 Jul 24, 2023
@mariajgrimaldi
Copy link
Member

@jyliugithub you can use this instance for tests: https://demo.openedx.overhang.io/ it's deployed using the latest Open edX release! Let us know how your testing goes.

@mariajgrimaldi
Copy link
Member

Hi @jyliugithub: do we have an update on this? Let us know what you need to test this out.

@heldersepu
Copy link

Could it be that the selector has the wrong option?

Image

@heldersepu
Copy link

heldersepu commented Oct 12, 2023

It looks that the selector option is indeed the problem, I change the italian option to it-IT and save and it shows correctly

Screenshot from 2023-10-11 23-15-34

Same with German, changing the option to de-DE did the trick:
image

@heldersepu
Copy link

heldersepu commented Nov 1, 2023

PR was merged, this issue can be closed...
a lot more talk on translations/Internationalization happening on the slack Open edX Transifex Working Group

@cmltaWt0 cmltaWt0 removed this from the Quince.1 milestone Jan 8, 2024
@cmltaWt0 cmltaWt0 added this to the Quince.2 milestone Jan 8, 2024
@mariajgrimaldi mariajgrimaldi modified the milestones: Quince.2, Quince.3 Feb 12, 2024
@mariajgrimaldi mariajgrimaldi modified the milestones: Quince.3, Redwood.1 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

10 participants