fix: Indicate this package is for the whole Open edX project #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arbrandes or @brian-smith-tcril is this a change we can make? I was updating https://docs.openedx.org/en/latest/developers/references/legacy_guide/style_guides/sass-guidelines.html to use "Open edX" instead of "edX" (openedx/docs.openedx.org#414) and wanted to match the README on this project... assuming this package is actually used by the whole project |
brian-smith-tcril
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
This package is used by paragon, course-authoring, edx-platform, publisher, and edx-bootstrap
Based on that, I think this change makes sense.
I left one suggestion to ensure all the table of contents links still work, assuming that is addressed this LGTM!
sarina
force-pushed
the
sarina/open-edx
branch
from
1e61e38 to
4221464
Compare
|
🎉 This PR is included in version 2.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.