Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to disable SelectMenu #3138

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

alangsto
Copy link
Contributor

@alangsto alangsto commented Jul 16, 2024

Description

I noticed that passing disabled as a prop to the SelectMenu component in a PR that I was working was not having the desired effect. That is because the Button component in the SelectMenu component is wrapped by a div that is receiving the additional props.

I opted to add an additional disabled prop to the SelectMenu component with a default value of false. This additional prop is then used to determine whether or not the button is disabled or not.

Deploy Preview

https://deploy-preview-3138--paragon-openedx.netlify.app/components/menu/select-menu/

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit fd1e7fd
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6696a646384f5f00099136c5
😎 Deploy Preview https://deploy-preview-3138--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rijuma rijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (cecbc9f) to head (fd1e7fd).
Report is 142 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3138   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         249      249           
  Lines        4388     4388           
  Branches     1035     1037    +2     
=======================================
  Hits         4092     4092           
  Misses        290      290           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alangsto alangsto merged commit c579d88 into master Jul 17, 2024
10 checks passed
@alangsto alangsto deleted the alangsto/add_select_menu_disable branch July 17, 2024 12:15
@openedx-semantic-release-bot

🎉 This PR is included in version 22.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants