-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to disable SelectMenu #3138
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3138 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 249 249
Lines 4388 4388
Branches 1035 1037 +2
=======================================
Hits 4092 4092
Misses 290 290
Partials 6 6 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 22.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
I noticed that passing
disabled
as a prop to theSelectMenu
component in a PR that I was working was not having the desired effect. That is because theButton
component in theSelectMenu
component is wrapped by a div that is receiving the additional props.I opted to add an additional
disabled
prop to theSelectMenu
component with a default value offalse
. This additional prop is then used to determine whether or not the button is disabled or not.Deploy Preview
https://deploy-preview-3138--paragon-openedx.netlify.app/components/menu/select-menu/
Merge Checklist
example
app?Post-merge Checklist