Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [BD-46] Revision of Core design token #3048

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented May 13, 2024

Description

  • The SCSS variables of the core directory were checked
  • Added/corrected design tokens relative for core directory

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please request an a11y review for the PR in the #wg-paragon Open edX Slack channel.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label May 13, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 13, 2024

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as draft May 13, 2024 08:45
Copy link

netlify bot commented May 13, 2024

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7b5369d
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6643859e6754ef0008e51004
😎 Deploy Preview https://deploy-preview-3048--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/revision-of-token-design-core branch from 9719e33 to 4c3e893 Compare May 13, 2024 08:46
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (146897a) to head (7b5369d).
Report is 404 commits behind head on alpha.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #3048   +/-   ##
=======================================
  Coverage   93.68%   93.68%           
=======================================
  Files         229      229           
  Lines        3740     3740           
  Branches      899      899           
=======================================
  Hits         3504     3504           
  Misses        231      231           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PKulkoRaccoonGang
Copy link
Contributor Author

@brian-smith-tcril after merging the updated alpha branch, only the last commit remains in this PR

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is so large my browser is freezing when viewing the files changed, but since most of the changes are from the merge, I decided to just review:

and they all LGTM! Thank you so much for this!

@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/revision-of-token-design-core branch from 4c3e893 to 7b5369d Compare May 14, 2024 15:39
@PKulkoRaccoonGang PKulkoRaccoonGang marked this pull request as ready for review May 14, 2024 15:39
@brian-smith-tcril brian-smith-tcril merged commit deebb2e into openedx:alpha May 14, 2024
10 checks passed
@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0-alpha.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot

🎉 This PR is included in version 23.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants