Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] fix: fixed Tooltip zindex in FullscreenModal #2621

Merged

Conversation

PKulkoRaccoonGang
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang commented Sep 12, 2023

Description

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the blended PR is managed through 2U's blended developmnt program label Sep 12, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for paragon-openedx ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 62cfb76
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/6500da700ace910008e32fd7
😎 Deploy Preview https://deploy-preview-2621--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (23b83c5) 91.81% compared to head (62cfb76) 91.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2621   +/-   ##
=======================================
  Coverage   91.81%   91.81%           
=======================================
  Files         235      235           
  Lines        4217     4217           
  Branches     1020     1020           
=======================================
  Hits         3872     3872           
  Misses        341      341           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang This solution only fixes the problem on the docs site. Have you checked whether this issue is reproducible in the example MFE? If it is, then we'll need to fix that too.

@viktorrusakov viktorrusakov linked an issue Sep 13, 2023 that may be closed by this pull request
@PKulkoRaccoonGang
Copy link
Contributor Author

PKulkoRaccoonGang commented Sep 13, 2023

@PKulkoRaccoonGang This solution only fixes the problem on the docs site. Have you checked whether this issue is reproducible in the example MFE? If it is, then we'll need to fix that too.

@viktorrusakov I checked, and the problem is only related to the documentation site 💯

@viktorrusakov
Copy link
Contributor

@PKulkoRaccoonGang Thanks! LGTM then 🙂

@viktorrusakov viktorrusakov merged commit 97b0229 into openedx:master Sep 13, 2023
9 checks passed
@openedx-webhooks
Copy link

@PKulkoRaccoonGang 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 21.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edx-semantic-release
Copy link
Contributor

🎉 This PR is included in version 22.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blended PR is managed through 2U's blended developmnt program released on @alpha released
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Displaying the Tooltip component inside the FullscreenModal
4 participants