Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] RTL best practices and naming/structure conventions #2619

Closed
brian-smith-tcril opened this issue Sep 12, 2023 · 1 comment
Closed

Comments

@brian-smith-tcril
Copy link
Contributor

During the review process for #2611, a few comments were left about undocumented best practices.

RTL Best Practices

Naming conventions

  • Use kebab-case for test ids (comment)

Structure

  • Put common test imports in setupTests.js (comment)

It'd be nice to have these (and any other good patterns) documented somewhere (ideally with links to good real-world examples from throughout the codebase).

I'm not sure where the best place for this documentation to live would be. It doesn't quite feel like it fits with the rest of what is in the decisions directory, and it's not exactly Paragon specific.

@brian-smith-tcril
Copy link
Contributor Author

In order to consolidate discussion around best practices in a non-paragon-specific location, I've created openedx/docs.openedx.org#380 and I will be closing this issue.

@brian-smith-tcril brian-smith-tcril closed this as not planned Won't fix, can't repro, duplicate, stale Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant