Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Special support for XBlocks #593

Merged

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Aug 23, 2023

feat: Special support for XBlocks

XBlocks require text.po and textjs.po instead of django.po and djangojs.po. This PR will add support to find XBlock translation files and rename them to django during translation extraction.

Why is this needed?

After moving along with standardizing make extract_translations in XBlocks; we found that it's safer to keep text.po and textjs.po as the translation domains for XBlocks. It's to preserve compatibility with in-repo translations since it'll be used for a while by the community

See this related conversation openedx/edx-cookiecutters#382 (comment)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 23, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 23, 2023

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.support-xblocks branch from a584dd8 to b4e34f0 Compare August 24, 2023 10:16
@shadinaif shadinaif marked this pull request as ready for review August 24, 2023 12:00
@shadinaif
Copy link
Contributor Author

This is ready @OmarIthawi @brian-smith-tcril

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'll wait to see if @OmarIthawi has any feedback before merging.

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadinaif I agree with the overall process. However, the implementation is becoming a bit cumbersome.

Nevertheless, I think we should refactor this file eventually. Therefore, I've added an issue for that:

XBlocks require text.po and textjs.po instead of django.po and djangojs.po

Refs: FC-0012 OEP-58
@shadinaif shadinaif force-pushed the shadinaif/FC-0012-OEP-58.support-xblocks branch from b4e34f0 to 0fa68f0 Compare August 31, 2023 09:07
@OmarIthawi OmarIthawi merged commit fbc8ab0 into openedx:main Aug 31, 2023
3 checks passed
@openedx-webhooks
Copy link

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi OmarIthawi deleted the shadinaif/FC-0012-OEP-58.support-xblocks branch August 31, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants