Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use LearnerLicenseSerializer in LicenseActivationView #741

Merged
merged 2 commits into from
Nov 20, 2024
Merged

fix: use LearnerLicenseSerializer in LicenseActivationView #741

merged 2 commits into from
Nov 20, 2024

Conversation

adamstankiewicz
Copy link
Member

Description

  • When testing license activation again since adding serializers to the BFF in enterprise-access, it was observed the license activation response is not parity with the learner-licenses API data, where it should have a nested subscription_plan. This PR migrates LicenseSerializer -> LearnerLicenseSerializer in LicenseActivationView (non-breaking change).

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@adamstankiewicz
Copy link
Member Author

Closing and re-opening to see if the CI will start as it's been "queued" for 10+ minutes.

@adamstankiewicz adamstankiewicz merged commit 7958944 into master Nov 20, 2024
9 checks passed
@adamstankiewicz adamstankiewicz deleted the ags/license-activation-serializer branch November 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveagent57 iloveagent57 iloveagent57 approved these changes

@macdiesel macdiesel macdiesel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamstankiewicz @macdiesel @iloveagent57