Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove the old fields in user agreement model #725

Merged
merged 1 commit into from
Oct 23, 2024
Merged

refactor: remove the old fields in user agreement model #725

merged 1 commit into from
Oct 23, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 22, 2024 •
edited
Loading

Description

Remove the old field references from the userAgreement model.

Link to the associated ticket: https://2u-internal.atlassian.net/browse/ENT-9615

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

mahamakifdar19
mahamakifdar19 reviewed Oct 22, 2024
View reviewed changes
Copy link
Contributor

@mahamakifdar19 mahamakifdar19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jajjibhai008 There’s no migration included to reflect the field removals?

@jajjibhai008
Copy link
Contributor Author

@jajjibhai008 There’s no migration included to reflect the field removals?

@mahamakifdar19 there will be a separate PR for migration. I will create after the deployment of this PR.
Referende document: https://openedx.atlassian.net/wiki/spaces/AC/pages/23003228/Everything+About+Database+Migrations#EverythingAboutDatabaseMigrations-Howtorenameacolumn

saleem-latif
saleem-latif requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@saleem-latif saleem-latif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to run migrations commands include those files as well.

@jajjibhai008
Copy link
Contributor Author

@jajjibhai008 There’s no migration included to reflect the field removals?

@mahamakifdar19 there will be a separate PR for migration. I will create after the deployment of this PR.
Referende document: https://openedx.atlassian.net/wiki/spaces/AC/pages/23003228/Everything+About+Database+Migrations#EverythingAboutDatabaseMigrations-Howtorenameacolumn

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9615-2 branch from da6a622 to 194c8c1 Compare October 23, 2024 07:50
@jajjibhai008 jajjibhai008 merged commit eac593b into master Oct 23, 2024
5 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9615-2 branch October 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahamakifdar19 mahamakifdar19 mahamakifdar19 approved these changes

@saleem-latif saleem-latif saleem-latif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jajjibhai008 @saleem-latif @mahamakifdar19