Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Django 4.2 #518

Closed
wants to merge 1 commit into from

Conversation

raymond1242
Copy link

@raymond1242 raymond1242 commented Sep 7, 2023

Description

Django 4.2 Upgrade

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 7, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 7, 2023

Thanks for the pull request, @raymond1242! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 8, 2023
@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 15, 2023
@mphilbrick211
Copy link

Hi @raymond1242! Just flagging that there's a failing check.

@raymond1242
Copy link
Author

raymond1242 commented Sep 15, 2023 via email

@raymond1242 raymond1242 changed the title [license-manager]: Django 4.2 Upgrade chore: upgrade Django 4.2 Sep 19, 2023
@raymond1242 raymond1242 force-pushed the django-upgrade branch 2 times, most recently from a623438 to 64c37c5 Compare September 19, 2023 05:16
@raymond1242
Copy link
Author

raymond1242 commented Sep 19, 2023

Hi @mphilbrick211! I fixed the error, could you please approve the workflows

@raymond1242 raymond1242 force-pushed the django-upgrade branch 2 times, most recently from bb025f5 to 4f1e1bd Compare September 22, 2023 14:17
@raymond1242
Copy link
Author

raymond1242 commented Sep 28, 2023

Hi @mphilbrick211, I have already completed all the steps of the issue and all tests were green, due to main branch updating conflict I had to rebase the branch to solve conflicts and it sends another approval check, that's the reason tests are yellow now. I'm waiting for your approval and review 🙌🏻.
Additionally, I created this thread where I comment the approach used and future improvements.

@mphilbrick211
Copy link

Thanks @raymond1242! I will look into getting tests run for you.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 3, 2023
@e0d
Copy link

e0d commented Oct 10, 2023

@raymond1242 looks like there are some failures. Can you have a look? It's possible some code related to your changes changed out from under you.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2023
@mphilbrick211
Copy link

@raymond1242 looks like there are some failures. Can you have a look? It's possible some code related to your changes changed out from under you.

Hi @raymond1242! Just following up on this :)

@mphilbrick211
Copy link

Hi @raymond1242 - just checking in to see if you plan on pursuing this pull request?

CC: @openedx/build-test-release-wg-security-patchers - just in case someone can push this through if needed.

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Dec 11, 2023
@raymond1242
Copy link
Author

Hi @mphilbrick211, I'm going to remove this PR

@openedx-webhooks
Copy link

@raymond1242 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive PR author has been unresponsive for several months open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants