Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example/src/apple.jpg is 2.48 MB - this is too big #567

Closed
davidjoy opened this issue Jul 9, 2024 · 2 comments
Closed

example/src/apple.jpg is 2.48 MB - this is too big #567

davidjoy opened this issue Jul 9, 2024 · 2 comments
Labels
released on @alpha released

Comments

@davidjoy
Copy link
Contributor

davidjoy commented Jul 9, 2024 •
edited
Loading

The example app has a picture of an apple (example/src/apple.jpg) that is 2.48 MB. I would suggest resizing and cropping it down to a 300x300 or so picture of an Apple. It serves as a test of how the image optimization plugins are working, and we should still be able to see a change with a much smaller file. 300x300 ought to be about 60 KB.
@davidjoy davidjoy changed the title example/src/apple.svg is 2.48 MB - this is too big example/src/apple.jpg is 2.48 MB - this is too big Jul 9, 2024
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 9, 2024
@ghassanmas
build: eculde example directory for npm resolved openedx#567
11eb137
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 9, 2024
@ghassanmas
build: eculde example directory for npm resolves openedx#567
7f60066
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 9, 2024
@ghassanmas
build: exclude example directory for npm resolves openedx#567
3782d1e
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 10, 2024
@ghassanmas
build: exclude example directory for npm & compress image resolves op…
042696d 
…enedx#567
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 10, 2024
@ghassanmas
build: exclude example directory for npm & compress image resolves op…
27182e5 
…enedx#567
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 12, 2024
@ghassanmas
build: exclude example directory for npm & compress image resolves op…
9c2cf25 
…enedx#567
ghassanmas added a commit to ghassanmas/frontend-build that referenced this issue Jul 17, 2024
@ghassanmas
build: specify files in package.json & compress image resolves opened…
8f2df76 
…x#567
@dcoa dcoa closed this as completed in 3077617 Jul 19, 2024
@openedx-semantic-release-bot
Copy link

🎉 This issue has been resolved in version 14.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This issue has been resolved in version 15.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @alpha released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidjoy @openedx-semantic-release-bot