Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate unused verification attempt details code #430

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

alangsto
Copy link
Contributor

COSMO-491

This PR removes code related to the /api/user/v1/accounts/verifications/${attemptId}/ endpoint, which is no longer used in the support MFE, and is being deprecated in the LMS.

@alangsto alangsto force-pushed the alangsto/deprecate_verification_attempt_details branch from 0ee2850 to 527399e Compare September 30, 2024 14:53
@alangsto alangsto force-pushed the alangsto/deprecate_verification_attempt_details branch from 527399e to 2d07f5c Compare September 30, 2024 14:57
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (25a0d32) to head (2d07f5c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   84.34%   84.31%   -0.03%     
==========================================
  Files         185      185              
  Lines        3857     3850       -7     
  Branches      943      943              
==========================================
- Hits         3253     3246       -7     
  Misses        581      581              
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alangsto alangsto merged commit 5ae8cec into master Sep 30, 2024
7 checks passed
@alangsto alangsto deleted the alangsto/deprecate_verification_attempt_details branch September 30, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants