Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch frontend-build deployment #1350

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

leangseu-edx
Copy link
Contributor

This pr is similar to openedx/frontend-app-learner-record#302

The can be remove once openedx/frontend-build#515 is merged

@@ -84,6 +85,7 @@
"jest": "^26.6.3",
"jest-console-group-reporter": "^1.0.1",
"jest-when": "^3.6.0",
"patch-package": "^8.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the intent of using this package for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch-package will try to read @openedx+frontend-build+13.0.30.patch file after install. If you look at the file @openedx+frontend-build+13.0.30.patch, it is just telling node_module/@openedx/frontend-build to update specific file. Essentially the change for the that was just so webpack would pick up JS_CONFIG_FILEPATH environment variable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting; this does seem pretty complex though. What's the need for injecting this patch code here instead of updating the https://github.com/openedx/frontend-build package?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NVM, I see that this is a temporary fix for that pr in the frontend-build like you mention in the PR description,

@BrandonHBodine BrandonHBodine self-requested a review April 11, 2024 20:24
@leangseu-edx leangseu-edx enabled auto-merge (squash) April 12, 2024 15:07
@leangseu-edx leangseu-edx disabled auto-merge April 12, 2024 15:13
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (9423a88) to head (eafd3c0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1350   +/-   ##
=======================================
  Coverage   88.25%   88.25%           
=======================================
  Files         293      293           
  Lines        4997     4997           
  Branches     1267     1264    -3     
=======================================
  Hits         4410     4410           
  Misses        571      571           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leangseu-edx leangseu-edx merged commit 1086367 into master Apr 12, 2024
7 checks passed
@leangseu-edx leangseu-edx deleted the lk/patch-plugin-deploy branch April 12, 2024 15:28
@arbrandes
Copy link

@leangseu-edx, we're probably going to have to remove this unless a compelling reason is found for this .env variable to exist in the first place. See openedx/frontend-build#515 (comment).

@bradenmacdonald
Copy link
Contributor

@leangseu-edx @arbrandes Is this patch still doing anything? I'd like to remove it, but it's unclear if it's still useful or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants