Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update to header with new FPF pluginProps #1525

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: update to header with new FPF pluginProps #1525

merged 1 commit into from
Nov 22, 2024
+7 −6

Conversation

brian-smith-tcril
Copy link
Contributor

backport of #1524

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 18, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (6f11596) to head (bc82114).
Report is 1 commits behind head on open-release/sumac.master.

Additional details and impacted files 
@@                    Coverage Diff                     @@
##           open-release/sumac.master    #1525   +/-   ##
==========================================================
  Coverage                      88.70%   88.70%           
==========================================================
  Files                            313      313           
  Lines                           5505     5505           
  Branches                        1328     1365   +37     
==========================================================
  Hits                            4883     4883           
+ Misses                           605      604    -1     
- Partials                          17       18    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes
arbrandes approved these changes Nov 22, 2024
View reviewed changes
Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@brian-smith-tcril brian-smith-tcril merged commit 4edaa1a into openedx:open-release/sumac.master Nov 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrandes arbrandes arbrandes approved these changes

Assignees
No one assigned
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-smith-tcril @open-craft-grove @arbrandes