-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin slot to Footer using FPF #302
Conversation
* env.config.jsx won't be able to use 'import' statement for FPF if 'require' statement remains in webpack config * the 'require' statement was used in dev config to use PORT provided by env.config * the 'require' statment was used in prod config to assign some env variables if they existed in JS config
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #302 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 27 27
Lines 403 403
Branches 85 85
=======================================
Hits 283 283
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🎈
+ staticAssetUrl: envConfig.BASE_URL || process.env.BASE_URL, | ||
// upload source maps in prod builds only | ||
noop: typeof process.env.NEW_RELIC_ADMIN_KEY === 'undefined', | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to have to remove this patch, I think. See openedx/frontend-build#515 (comment).
Description
This PR installs the master branch of Frontend Plugin Framework library into Learner Record. The primary goal of this PR is:
This PR also includes:
require
statement, which prevented anyimport
in theenv.config.js
.To test this locally:
npm install
env.config.jsx
file that includes the following:npm run start
<div>
should be underneath the<Footer>
tag when you inspect the source code.Ways to play around with this
<p>
inside thediv
that shows some text.keepDefault
tofalse
in JS config to hide Footer and still insert emptydiv
env.config.jsx
completely to ensure Footer isn't affected by a missing config (note:keepDefault
defaults totrue
on FPF's side, which is why the Footer is still present without the JS config)Screenshots
Insert empty
div
pluginRemove
env.config.jsx
entirelyAPER-3275