Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated frontend-build & frontend-platform major versions #246

Merged
merged 9 commits into from
May 21, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Dec 5, 2023

Description
Major version upgrades, Updating frontend-build to v14 & frontend-platform to v8 along with respective edx packages

@justinhynes
Copy link
Contributor

Hi @BilalQamar95,

This is a draft PR that doesn't look like it has moved much lately. Is this still planned or required work? Can this be closed?

@BilalQamar95
Copy link
Contributor Author

Hi @BilalQamar95,

This is a draft PR that doesn't look like it has moved much lately. Is this still planned or required work? Can this be closed?

@justinhynes This is still planned from our side, some other PRs of ours are awaiting review, once they are merged dependency issues in this will be cleared out.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.73%. Comparing base (4445fe3) to head (55cad26).
Report is 28 commits behind head on master.

Current head 55cad26 differs from pull request most recent head fa00386

Please upload reports for the commit fa00386 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   70.87%   70.73%   -0.15%     
==========================================
  Files          28       28              
  Lines         412      410       -2     
  Branches       89       87       -2     
==========================================
- Hits          292      290       -2     
  Misses        119      119              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 changed the title chore: bumped jest to v29 feat: updated frontend-build & frontend-platform major versions Apr 23, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review May 17, 2024 10:21
@justinhynes
Copy link
Contributor

HI @BilalQamar95 -- it looks like you marked this as ready, but there are a couple of conflicts that need to be resolved in the package.json and package-lock.json files. Any chance you can fix this up and then I can get this on my radar this week while I'm on call?

@justinhynes justinhynes added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label May 20, 2024
@BilalQamar95
Copy link
Contributor Author

HI @BilalQamar95 -- it looks like you marked this as ready, but there are a couple of conflicts that need to be resolved in the package.json and package-lock.json files. Any chance you can fix this up and then I can get this on my radar this week while I'm on call?

@justinhynes I have resolved the conflicts

@BilalQamar95 BilalQamar95 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 21, 2024
@justinhynes justinhynes merged commit 562af36 into master May 21, 2024
6 checks passed
@justinhynes justinhynes deleted the bilalqamar95/jest-v29-upgrade branch May 21, 2024 20:29
@justinhynes justinhynes removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label May 22, 2024
@BilalQamar95 BilalQamar95 self-assigned this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants