-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated frontend-build & frontend-platform major versions #246
Conversation
Hi @BilalQamar95, This is a draft PR that doesn't look like it has moved much lately. Is this still planned or required work? Can this be closed? |
@justinhynes This is still planned from our side, some other PRs of ours are awaiting review, once they are merged dependency issues in this will be cleared out. |
…ner-record into bilalqamar95/jest-v29-upgrade
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 70.87% 70.73% -0.15%
==========================================
Files 28 28
Lines 412 410 -2
Branches 89 87 -2
==========================================
- Hits 292 290 -2
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
…ner-record into bilalqamar95/jest-v29-upgrade
…ner-record into bilalqamar95/jest-v29-upgrade
HI @BilalQamar95 -- it looks like you marked this as ready, but there are a couple of conflicts that need to be resolved in the package.json and package-lock.json files. Any chance you can fix this up and then I can get this on my radar this week while I'm on call? |
…ner-record into bilalqamar95/jest-v29-upgrade
@justinhynes I have resolved the conflicts |
Description
Major version upgrades, Updating
frontend-build
to v14 &frontend-platform
to v8 along with respective edx packages