feat: make the "loading" message be accurate #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* While a program record is loading we now get a loading message * spun off a second private ticket APER-2924, to fix the API problem which makes it impossible to accurately report that a URL is invalid * Left the stub method in place because I didn't want to lose the translation strings people have made. FIXES: APER-2190
FIXES: APER-2190
* Getting rid of the 404 test with the old error message * replacing with a no return test with the new loading message FIXES: APER-2190
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 69.60% 69.60%
=======================================
Files 27 27
Lines 408 408
Branches 90 90
=======================================
Hits 284 284
Misses 123 123
Partials 1 1
☔ View full report in Codecov by Sentry. |
MaxFrank13
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
This looks great! Thanks for addressing this. One minor suggestion that is not blocking is to use the Paragon Spinner component if you want to get a little fancy with it.
deborahgu
deleted the
dkaplan1/APER-2190_page-you're-looking-for-is-unavailable-error-flashes-on-lr-mfe-before-program-record-has-rendered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: APER-2190