Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed module button href #508

Conversation

PKulkoRaccoonGang
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang commented Nov 20, 2024

Warning

Description

This PR includes changes to update the URLs in the LearnerDashboardHeader components to use the configured LMS base URL instead of hardcoded paths. This ensures that the application correctly redirects to the dashboard in different environments.

Screen.Recording.2024-11-20.at.12.26.06.mov

@PKulkoRaccoonGang PKulkoRaccoonGang requested a review from a team as a code owner November 20, 2024 10:24
@openedx-webhooks
Copy link

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2024
@PKulkoRaccoonGang PKulkoRaccoonGang force-pushed the Peter_Kulko/header-module-button branch 2 times, most recently from 92110cb to f3fdc31 Compare November 20, 2024 10:39
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 21, 2024
@jsnwesson
Copy link
Contributor

@PKulkoRaccoonGang just wanted to confirm, do you have merge permissions for this repo or do you need one of us to merge it?

@itsjeyd
Copy link

itsjeyd commented Dec 5, 2024

@PKulkoRaccoonGang Friendly ping on @jsnwesson's question above ⬆️ 🙂

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 5, 2024
@cmltaWt0 cmltaWt0 merged commit 49d64ff into openedx:open-release/redwood.master Dec 12, 2024
4 checks passed
@PKulkoRaccoonGang
Copy link
Author

Hey @jsnwesson, I don't have merge permissions for this repo, maybe @cmltaWt0 will do it soon

@PKulkoRaccoonGang PKulkoRaccoonGang self-assigned this Dec 12, 2024
@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants