-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed module button href #508
fix: fixed module button href #508
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
92110cb
to
f3fdc31
Compare
f3fdc31
to
f6202bc
Compare
@PKulkoRaccoonGang just wanted to confirm, do you have merge permissions for this repo or do you need one of us to merge it? |
@PKulkoRaccoonGang Friendly ping on @jsnwesson's question above ⬆️ 🙂 |
49d64ff
into
openedx:open-release/redwood.master
Hey @jsnwesson, I don't have merge permissions for this repo, maybe @cmltaWt0 will do it soon |
Description
This PR includes changes to update the URLs in the
LearnerDashboardHeader
components to use the configured LMS base URL instead of hardcoded paths. This ensures that the application correctly redirects to the dashboard in different environments.Screen.Recording.2024-11-20.at.12.26.06.mov