Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grade value is displayed in the modal #390

Merged
merged 1 commit into from
May 1, 2024

Conversation

DmytroAlipov
Copy link

TL;DR -

Original Grade value is not displayed:
gr_0

This value was available on the Palm release:
gr_1

That's how it was in Palm

This is the data contained in selectors.grades.useGradeData:

{
    "courseId": "course-v1:RG+New-course-2+2024",
    "filteredUsersCount": 10,
    "totalUsersCount": 11,
    "gradeFormat": "percent",
    "showSpinner": false,
    "gradeOverrideCurrentEarnedGradedOverride": null,
    "gradeOverrideHistoryResults": [],
    "gradeOriginalEarnedGraded": 1,
    "gradeOriginalPossibleGraded": 1,
    "nextPage": null,
    "prevPage": null,
    "showSuccess": false,
}

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review

Testing Instructions

  1. As instructor open Instructor tab
  2. go to Student admin
  3. click View Gradebook
  4. Click on available grade:
    gp_3
  5. Check Original Grade value

After these fixes everything works correctly:
gr_2

FYI: @openedx/content-aurora

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner April 21, 2024 11:03
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 21, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov added the bug Report of or fix for something that isn't working as intended label Apr 21, 2024
@mphilbrick211 mphilbrick211 requested review from farhaanbukhsh and removed request for a team April 22, 2024 17:58
@mphilbrick211 mphilbrick211 assigned arbrandes and unassigned arbrandes Apr 22, 2024
@mphilbrick211 mphilbrick211 requested a review from arbrandes April 22, 2024 17:59
@mphilbrick211
Copy link

Hi @arbrandes and @farhaanbukhsh! Would one of you be able to take a look at this? Thanks!

@farhaanbukhsh
Copy link
Member

@mphilbrick211 I can have a look at this in this sprint :)

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@@ -22,7 +22,7 @@ export const HistoryKeys = StrictDict({
*/
export const ModalHeaders = () => {
const { assignmentName, updateUserName } = selectors.app.useModalData();
const { currentGrade, originalGrade } = selectors.grades.useGradeData();
const { gradeOverrideCurrentEarnedGradedOverride, gradeOriginalEarnedGraded } = selectors.grades.useGradeData();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are horribly long variable names, but yeah, not much we can do.

@arbrandes arbrandes merged commit 75725c1 into openedx:master May 1, 2024
5 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-original-grade-value branch May 2, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants