-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "An unexpected error occurred" after second opening any grade #387
fix: "An unexpected error occurred" after second opening any grade #387
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 140 140
Lines 1356 1356
Branches 264 265 +1
=======================================
Hits 1288 1288
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Hi @DmytroAlipov! I believe Aurora is no longer maintaining this repo, so I'm going to work on finding another reviewer for these. Thanks! |
I have a strong suspicion that this will solve #384. Thanks, I'll review ASAP! |
@arbrandes Could you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks safe enough. Approved!
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Hi! I found a bug.
Open Instructor -> Student admin -> View gradebook
Click on some grade
Set new grade or just click Cancel
Open same grade or another one
This happens because
doneViewingAssignment()
executes when the modal window closes. The redux state is being cleaned, namely,gradeOverrideHistoryResults
is removed.Because of this, when we access this element again, we do not get the expected iterable object (list), but we get an
undefined
.Previously, this was eliminated by the default value.
My suggestion is to also make the value default
[]
ifundefined
.