Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sidebar scrolling and adaptation for mobile #370

Conversation

ihor-romaniuk
Copy link
Contributor

TL;DR -

This pull request contains minor fixes related to the responsiveness of the blocks for mobile phones. All the before and after screenshots are below.

Related Pull Requests
PR to the open-release/palm.master branch: #362
PR to the master branch: #363

What changed?

  • fixed text overload in the title when the course ID is too long
Before After
image image
  • fixed appearance and scrolling of the sidebar
Before After
image image
image image
  • Fixed adaptation of the search and filter buttons on mobile phones.
Before After
image image
  • removed excess empty space under the main table of contents
Before After
image image
  • fix adaptation modal content to mobile view
Before After
image image

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

- fix text overload in heading
- fix appearance for sidebar with a short main content
- fix transformation of search and filter button on mobile
- fix extra empty space below main content table
- fix adaptation modal content to mobile view
@ihor-romaniuk ihor-romaniuk requested a review from a team as a code owner October 27, 2023 07:36
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 27, 2023

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@b536180). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #370   +/-   ##
=============================================================
  Coverage                              ?   94.98%           
=============================================================
  Files                                 ?      140           
  Lines                                 ?     1357           
  Branches                              ?      264           
=============================================================
  Hits                                  ?     1289           
  Misses                                ?       60           
  Partials                              ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Oct 27, 2023
@mphilbrick211
Copy link

Hi @openedx/content-aurora! This is ready for review / merge, after you're all set with the master #363

@cmltaWt0 cmltaWt0 added product review PR requires product review before merging and removed product review PR requires product review before merging labels Feb 6, 2024
@mphilbrick211 mphilbrick211 added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Mar 20, 2024
@mphilbrick211 mphilbrick211 removed the request for review from a team April 2, 2024 18:38
@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review and removed product review PR requires product review before merging labels Apr 2, 2024
@mphilbrick211 mphilbrick211 requested a review from arbrandes April 2, 2024 18:39
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master is approved, so is this.

@arbrandes arbrandes merged commit e795163 into openedx:open-release/quince.master Apr 3, 2024
5 checks passed
@openedx-webhooks
Copy link

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants