Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: babel-plugin-react-intl to babel-plugin-formatjs migration #354

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

abdullahwaheed
Copy link
Contributor

@abdullahwaheed abdullahwaheed commented Oct 4, 2023

Upgraded to fronted-build v13 which migrates deprecated babel-plugin-react-intl to babel-plugin-formatjs.
Changed i18n_extract script in package.json accordingly

Epic Link

Migrate off babel-plugin-react-intl in favor of babel-plugin-formatjs

@abdullahwaheed abdullahwaheed requested a review from a team as a code owner October 4, 2023 14:49
@abdullahwaheed abdullahwaheed self-assigned this Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (247e9f3) 94.98% compared to head (cb5728b) 94.98%.
Report is 1 commits behind head on master.

❗ Current head cb5728b differs from pull request most recent head 14cd1ea. Consider uploading reports for the commit 14cd1ea to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files         140      140           
  Lines        1357     1357           
  Branches      264      264           
=======================================
  Hits         1289     1289           
  Misses         60       60           
  Partials        8        8           
Files Coverage Δ
...mponents/GradesView/GradebookTable/GradeButton.jsx 100.00% <100.00%> (ø)
src/components/GradesView/GradebookTable/hooks.jsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@mattcarter mattcarter merged commit bf3b37c into master Oct 11, 2023
3 checks passed
@mattcarter mattcarter deleted the abdullahwaheed/react-intl-to-formatjs branch October 11, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants