Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cohesion script and SSO issue #1332

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

awais-ansari
Copy link

INF-1661

  • Load cohesion script on app load.
  • Resolve userId issue on script load.
  • SSO provider issue while sending cohesion event

@awais-ansari awais-ansari requested a review from a team as a code owner October 18, 2024 14:22
@awais-ansari awais-ansari changed the title Aansari/cohesion script sso fix: cohesion script and SSO issue Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.94%. Comparing base (1477ed3) to head (30fcca7).
Report is 5 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/cohesion/index.js 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1332      +/-   ##
===========================================
- Coverage    86.57%   85.94%   -0.63%     
===========================================
  Files          134      140       +6     
  Lines         2413     2462      +49     
  Branches       669      669              
===========================================
+ Hits          2089     2116      +27     
- Misses         311      331      +20     
- Partials        13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari merged commit 9239df3 into 2u-main Oct 18, 2024
5 of 7 checks passed
@awais-ansari awais-ansari deleted the aansari/cohesion-script-sso branch October 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants