Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cohesion events tracking #1329

Merged
merged 4 commits into from
Oct 17, 2024
Merged

feat: added cohesion events tracking #1329

merged 4 commits into from
Oct 17, 2024

Conversation

ayesha-waris
Copy link

INF-1661

Description

Incorporating new events into the Authn MFE using Cohesion. This will allow the RV team to leverage these events effectively for their specific requirements.

Events

  • This event fires when a user submits their and clicks on "Create an account for free" CTA
  • This event fires when a user deselects the checkbox for "I agree that edx can send me marketing messages" CTA
  • This event fires when a user submits their and clicks on "Sign In" CTA

@ayesha-waris ayesha-waris requested a review from a team as a code owner October 15, 2024 11:54
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 40.27778% with 43 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (1477ed3) to head (d62a88e).
Report is 2 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/cohesion/index.js 0.00% 29 Missing and 5 partials ⚠️
src/cohesion/data/reducers.js 0.00% 4 Missing and 2 partials ⚠️
...gister/components/ConfigurableRegistrationForm.jsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1329      +/-   ##
===========================================
- Coverage    86.57%   85.23%   -1.35%     
===========================================
  Files          134      140       +6     
  Lines         2413     2485      +72     
  Branches       669      679      +10     
===========================================
+ Hits          2089     2118      +29     
- Misses         311      347      +36     
- Partials        13       20       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.eslintignore Outdated Show resolved Hide resolved
src/tracking/trackers/register.js Outdated Show resolved Hide resolved
src/tracking/trackers/login.js Outdated Show resolved Hide resolved
src/register/components/tests/ThirdPartyAuth.test.jsx Outdated Show resolved Hide resolved
src/login/messages.jsx Outdated Show resolved Hide resolved
src/login/tests/LoginPage.test.jsx Outdated Show resolved Hide resolved
src/login/LoginPage.jsx Outdated Show resolved Hide resolved
src/register/RegistrationPage.jsx Outdated Show resolved Hide resolved
src/register/components/ConfigurableRegistrationForm.jsx Outdated Show resolved Hide resolved
@ayesha-waris ayesha-waris merged commit 07ee239 into 2u-main Oct 17, 2024
5 of 7 checks passed
@ayesha-waris ayesha-waris deleted the Ayesha/INF-1657 branch October 17, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants