Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: password reset redirection #1300

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: password reset redirection #1300

merged 1 commit into from
Aug 29, 2024

Conversation

mubbsharanwar
Copy link
Contributor

Description

fix authenticated user redirects to 404 if the token is invalid for password reset

JIRA

[VAN-2052](https://2u-internal.atlassian.net/browse/ VAN-2052)

How Has This Been Tested?

tested through local testing

@mubbsharanwar mubbsharanwar requested a review from a team as a code owner August 20, 2024 13:55
syedsajjadkazmii
syedsajjadkazmii requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be query params. Would this still work?
Also dont we want to redirect to dashboard?

@mubbsharanwar
Copy link
Contributor Author

There can be query params. Would this still work? Also dont we want to redirect to dashboard?

We are adding a condition for RESET_PAGE all other cases are with query params.
Also, we are redirecting to the forget password page because unauthenticated users are redirected to the forget password page if the token is invalid.

@mubbsharanwar
fix: password reset redirection
3fcf7de 
fix authenticated user redirects to 404 if token is invalide for password reset
VAN-2052
@mubbsharanwar mubbsharanwar merged commit ecf4c3a into 2u-main Aug 29, 2024
5 checks passed
@mubbsharanwar mubbsharanwar deleted the manwar/VAN-2052 branch August 29, 2024 04:48
@mubbsharanwar mubbsharanwar restored the manwar/VAN-2052 branch September 6, 2024 13:42
mubbsharanwar added a commit that referenced this pull request Sep 12, 2024
@mubbsharanwar
fix: password reset redirection (#1300)
ac25489 
fix authenticated user redirects to 404 if token is invalide for password reset
VAN-2052
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syedsajjadkazmii syedsajjadkazmii syedsajjadkazmii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mubbsharanwar @syedsajjadkazmii