-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unification of the appearance of buttons #1091
feat: unification of the appearance of buttons #1091
Conversation
Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #1091 +/- ##
=============================================================
Coverage ? 86.97%
=============================================================
Files ? 124
Lines ? 2265
Branches ? 624
=============================================================
Hits ? 1970
Misses ? 286
Partials ? 9 ☔ View full report in Codecov by Sentry. |
Hi @openedx/vanguards! This is ready for review / merge once the master is all set. |
@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This pull request contains recommendations to improve the display of button blocks for oauth2 providers.
The main goal is to make the buttons appear uniform so that it looks more aesthetically pleasing and consistent.
Also, removing SCSS-specific variables and using the variables provided by the Paragon library.
Related Pull Requests
PR to the open-release/palm.master branch: #1090
PR to the master branch: #1092
Screenshots
Merge Checklist
Post-merge Checklist