Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump frontend-platform (#1076) #1082

Conversation

Syed-Ali-Abbas-Zaidi
Copy link
Contributor

Description

This PR resolves the PUBLIC_PATH configuration issue by upgrading frontend-platform from v5.0.0 to v5.5.4.

JIRA

XXX-XXXX

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if its not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/vanguards to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi requested a review from a team as a code owner October 17, 2023 07:06
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7b4714a) 86.97% compared to head (d7e9d85) 86.98%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1082   +/-   ##
=======================================
  Coverage   86.97%   86.98%           
=======================================
  Files         124      124           
  Lines        2265     2266    +1     
  Branches      624      624           
=======================================
+ Hits         1970     1971    +1     
  Misses        286      286           
  Partials        9        9           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi changed the base branch from master to open-release/quince.master October 17, 2023 11:06
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi merged commit 60e2119 into open-release/quince.master Oct 18, 2023
6 checks passed
@Syed-Ali-Abbas-Zaidi Syed-Ali-Abbas-Zaidi deleted the A-Abbas/bump-frontend-platform branch October 18, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants