-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed spacing in tablet version (palm.master) #1061
fix: Fixed spacing in tablet version (palm.master) #1061
Conversation
Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
We have created a ticket in the backlog for the review CC: @mphilbrick211 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/palm.master #1061 +/- ##
===========================================================
Coverage ? 83.42%
===========================================================
Files ? 101
Lines ? 2099
Branches ? 585
===========================================================
Hits ? 1751
Misses ? 335
Partials ? 13 ☔ View full report in Codecov by Sentry. |
We have not been able to reproduce the issue on palm.master. Also your changes affect the accent color in the title. Screen.Recording.2023-10-06.at.1.36.26.PM.mov |
Hi @vladislavkeblysh - Just flagging Zainab's comment above. |
Hi @vladislavkeblysh - following up on this! |
@zainab-amir Hi! However, if this part is shorter, for example, 'with Name' - then you will be able to see this issue (attached a screenshots) |
Hi @zainab-amir! When you get a chance to look at this, could you please also re-enable the checks to run? Thanks! |
b9a8592
to
e55f29d
Compare
Hi @mphilbrick211! The branch was rebased. Please, check it, thank you! |
c386ec7
into
openedx:open-release/palm.master
@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Fixed spacing in tablet version
Fixed spacing in authn title in tablet version
Screenshots/sandbox (optional):