Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed spacing in tablet version (palm.master) #1061

Conversation

vladislavkeblysh
Copy link
Contributor

Fixed spacing in tablet version

Fixed spacing in authn title in tablet version

Screenshots/sandbox (optional):

Screenshot 2023-09-19 at 12 52 15

@vladislavkeblysh vladislavkeblysh requested a review from a team as a code owner September 19, 2023 09:59
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 19, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 19, 2023

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@zainab-amir
Copy link
Contributor

We have created a ticket in the backlog for the review

CC: @mphilbrick211

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@1eaebeb). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master    #1061   +/-   ##
===========================================================
  Coverage                            ?   83.42%           
===========================================================
  Files                               ?      101           
  Lines                               ?     2099           
  Branches                            ?      585           
===========================================================
  Hits                                ?     1751           
  Misses                              ?      335           
  Partials                            ?       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zainab-amir
Copy link
Contributor

We have not been able to reproduce the issue on palm.master. Also your changes affect the accent color in the title.

Screen.Recording.2023-10-06.at.1.36.26.PM.mov

@mphilbrick211
Copy link

Hi @vladislavkeblysh - Just flagging Zainab's comment above.

@mphilbrick211
Copy link

Hi @vladislavkeblysh - Just flagging Zainab's comment above.

Hi @vladislavkeblysh - following up on this!

@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Oct 24, 2023
@vladislavkeblysh
Copy link
Contributor Author

@zainab-amir Hi!
You can't reproduce this bug because in your example, the part 'with Your Platform Name Here' is too long, and therefore it always ends up on the second line.

However, if this part is shorter, for example, 'with Name' - then you will be able to see this issue (attached a screenshots)

Screenshot 2023-10-09 at 18 02 38

Screenshot 2023-10-09 at 18 04 29

@mphilbrick211
Copy link

Hi @zainab-amir! When you get a chance to look at this, could you please also re-enable the checks to run? Thanks!

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Nov 14, 2023
@vladislavkeblysh vladislavkeblysh changed the title fix: [RGOeX-25958] fixed spacing in tablet version fix: Fixed spacing in tablet version (palm.master) Nov 25, 2023
@vladislavkeblysh
Copy link
Contributor Author

vladislavkeblysh commented Nov 25, 2023

Hi @mphilbrick211! The branch was rebased.
Also created MR on quince.master

Please, check it, thank you!

@zainab-amir zainab-amir merged commit c386ec7 into openedx:open-release/palm.master Nov 28, 2023
6 checks passed
@openedx-webhooks
Copy link

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes. waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants