feat: creates a modal to add members #1363
Conversation
katrinan029
force-pushed
the
knguyen2/ent-9602
branch
from
676580e to
5d9a849
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 85.72% 85.37% -0.35%
==========================================
Files 609 617 +8
Lines 13363 13474 +111
Branches 2812 2780 -32
==========================================
+ Hits 11455 11504 +49
- Misses 1838 1900 +62
Partials 70 70 ☔ View full report in Codecov by Sentry. |
| <h3> | ||
| <FormattedMessage | ||
| id="people.management.page.create.group.section.header" | ||
| defaultMessage="Create a custom group of members" |
There was a problem hiding this comment.
This title isn't needed for the Add members modal
| <Col> | ||
| <h4 className="mt-4">Add new members to your group</h4> | ||
| <p>Only members registered with your organization can be added to your group. Learn more</p> | ||
| <h4 className="mt-4">Group Name</h4> |
There was a problem hiding this comment.
"Group name" should be all caps, should add className="text-uppercase"
| <Row> | ||
| <Col> | ||
| <h4 className="mt-4">Add new members to your group</h4> | ||
| <p>Only members registered with your organization can be added to your group. Learn more</p> |
There was a problem hiding this comment.
Even though we might not have the help center doc yet, I think we could make this a hyperlink that just points to edx.org or something
| <h4 className="mt-2">Select group members</h4> | ||
| <p> | ||
| <FormattedMessage | ||
| id="people.management.page.create.group.csv.upload" |
There was a problem hiding this comment.
When I upload a large CSV, I'm getting two error states. I don't see any examples of this in Figma, and I think we might need to talk to Sophia about which one should be present
| import PropTypes from 'prop-types'; | ||
|
|
||
| const AddMemberTableAction = ({ openModal }) => ( | ||
| <Button iconBefore={Add} onClick={openModal} variant="outline-primary">Add members</Button> |
There was a problem hiding this comment.
I'm not actually seeing this button as a table action? The only way I'm able to open up the add members modal is a weird stray edit icon on the Group Detail card after the "View group progress" button
Description
Creates a modal to add members to an existing group
https://2u-internal.atlassian.net/browse/ENT-9602
For all changes
Only if submitting a visual change