-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed the display of the selection of available time zones #896
Conversation
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
995f8d4
to
7f31bf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 46.63% 46.66% +0.03%
==========================================
Files 122 117 -5
Lines 2552 2411 -141
Branches 672 641 -31
==========================================
- Hits 1190 1125 -65
+ Misses 1286 1212 -74
+ Partials 76 74 -2
☔ View full report in Codecov by Sentry. |
2793ece
to
89d1680
Compare
Could you please advise on what to do with test coverage? Before my pull request, the file frontend-app-account/src/account-settings/EditableSelectField.jsx had no test coverage at all. I added tests for this file, but the coverage actually decreased. |
@DmytroAlipov take a look at the indirect changes in CodeCov: There are two codecovs checks:
We can see your changes are 100% that is awesome, but somehow the project declines by tiny 0.13 (annoying I know) workaround add test to anything else in the project to help increase coverage and call it a day |
281d8ea
to
17cd03e
Compare
17cd03e
to
31c775b
Compare
@heldersepu done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mphilbrick211 just a friendly ping :) |
Thanks, @DmytroAlipov! I believe @openedx/2u-fed-bom and @Mashal-m might be out for the holidays, but pinging again just in case. |
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
An error was found when selecting a timezone in the user account.
In this PR, a time zone selection was added.
Then the select field was rewritten in PR. (Paragon form component deprecations)
However, these changes have broken the time zone selection field.
Before:
After: