Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the display of the selection of available time zones #896

Merged
merged 1 commit into from
Jan 1, 2024

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Oct 4, 2023

Description

An error was found when selecting a timezone in the user account.

In this PR, a time zone selection was added.
Then the select field was rewritten in PR. (Paragon form component deprecations)
However, these changes have broken the time zone selection field.

Before:

screen_91 screen_94

After:

screen_93 screen_92

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 4, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 4, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40103a2) 46.63% compared to head (31c775b) 46.66%.
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   46.63%   46.66%   +0.03%     
==========================================
  Files         122      117       -5     
  Lines        2552     2411     -141     
  Branches      672      641      -31     
==========================================
- Hits         1190     1125      -65     
+ Misses       1286     1212      -74     
+ Partials       76       74       -2     
Files Coverage Δ
src/account-settings/EditableSelectField.jsx 80.39% <100.00%> (+3.30%) ⬆️

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroAlipov DmytroAlipov force-pushed the fix-time-zone branch 3 times, most recently from 2793ece to 89d1680 Compare October 5, 2023 07:02
@DmytroAlipov
Copy link
Contributor Author

DmytroAlipov commented Oct 5, 2023

Could you please advise on what to do with test coverage? Before my pull request, the file frontend-app-account/src/account-settings/EditableSelectField.jsx had no test coverage at all. I added tests for this file, but the coverage actually decreased.

@heldersepu
Copy link
Contributor

heldersepu commented Oct 19, 2023

@DmytroAlipov take a look at the indirect changes in CodeCov:
https://app.codecov.io/gh/openedx/frontend-app-account/pull/896/indirect-changes

There are two codecovs checks:

  • codecov/project Failing after 1s — 46.50% (-0.13%) compared to ...
  • codecov/patch — 100.00% of diff hit (target 46.63%)

We can see your changes are 100% that is awesome, but somehow the project declines by tiny 0.13 (annoying I know) workaround add test to anything else in the project to help increase coverage and call it a day

@DmytroAlipov DmytroAlipov force-pushed the fix-time-zone branch 4 times, most recently from 281d8ea to 17cd03e Compare October 20, 2023 16:01
@DmytroAlipov
Copy link
Contributor Author

@heldersepu done!

Copy link
Contributor

@Mashal-m Mashal-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mphilbrick211
Copy link

Hi @Mashal-m! Are you able to merge this for us, along with its backport #895 ? Thanks!

@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211 just a friendly ping :)

@mphilbrick211
Copy link

Thanks, @DmytroAlipov! I believe @openedx/2u-fed-bom and @Mashal-m might be out for the holidays, but pinging again just in case.

@abdullahwaheed abdullahwaheed merged commit 5166546 into openedx:master Jan 1, 2024
8 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-time-zone branch January 2, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants