Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the display of the selection of available time zones (for Palm) #895

Conversation

DmytroAlipov
Copy link
Contributor

@DmytroAlipov DmytroAlipov commented Oct 4, 2023

Backport from the master.

Description

An error was found when selecting a timezone in the user account.

In this PR, a time zone selection was added.
Then the select field was rewritten in PR. (Paragon form component deprecations)
However, these changes have broken the time zone selection field.

Before:

screen_91 screen_94

After:

screen_92 screen_93

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 4, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 4, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov changed the title fix: Fixed the display of the selection of available time zones. fix: Fixed the display of the selection of available time zones (for Palm) Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/palm.master@03e3b67). Click here to learn what that means.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             open-release/palm.master     #895   +/-   ##
===========================================================
  Coverage                            ?   38.76%           
===========================================================
  Files                               ?      110           
  Lines                               ?     2291           
  Branches                            ?      625           
===========================================================
  Hits                                ?      888           
  Misses                              ?     1318           
  Partials                            ?       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. backport PR backports a change from main to a named release. labels Nov 15, 2023
@mphilbrick211
Copy link

Hi @abdullahwaheed and @Mashal-m! Would one of you be able to merge this for us? The master has been merged. Thanks!

@mphilbrick211
Copy link

Hi @openedx/2u-aperture! Would someone be able to please merge this for us? Thanks!

@abdullahwaheed abdullahwaheed merged commit c72411e into openedx:open-release/palm.master Apr 1, 2024
7 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-time-zone-palm branch April 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants