Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added notification preferences settings at account level #1159

Open
wants to merge 7 commits into
base: 2u-main
Choose a base branch
from

refactor: updated time

330a076
Select commit
Loading
Failed to load commit list.
Open

feat: added notification preferences settings at account level #1159

refactor: updated time
330a076
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 29, 2024 in 0s

58.06% (-0.57%) compared to f86261d

View this Pull Request on Codecov

58.06% (-0.57%) compared to f86261d

Details

Codecov Report

Attention: Patch coverage is 51.89873% with 38 lines in your changes missing coverage. Please review.

Project coverage is 58.06%. Comparing base (f86261d) to head (330a076).
Report is 3 commits behind head on 2u-main.

Files with missing lines Patch % Lines
src/notification-preferences/data/thunks.js 12.50% 17 Missing and 4 partials ⚠️
...cation-preferences/NotificationCoursesDropdown.jsx 72.72% 5 Missing and 1 partial ⚠️
src/notification-preferences/data/service.js 16.66% 5 Missing ⚠️
src/divider/Divider.jsx 0.00% 4 Missing ⚠️
src/notification-preferences/data/actions.js 50.00% 1 Missing ⚠️
src/notification-preferences/data/reducers.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u-main    #1159      +/-   ##
===========================================
- Coverage    58.62%   58.06%   -0.57%     
===========================================
  Files          117      119       +2     
  Lines         2335     2368      +33     
  Branches       643      648       +5     
===========================================
+ Hits          1369     1375       +6     
- Misses         905      927      +22     
- Partials        61       66       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.