-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make notification channel headings clickable in notification #983
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 56.50% 56.53% +0.02%
==========================================
Files 118 118
Lines 2435 2457 +22
Branches 652 654 +2
==========================================
+ Hits 1376 1389 +13
- Misses 988 997 +9
Partials 71 71 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case for this change other than this PR LGTM.
INF-1062
Explanation:
The code for the notification channel headings has been made more generic. An on-click event handler has been implemented along with relevant updates in the selectors, thunk, and service files needed for it.
The implementation for the new back-end API can be found in PR