Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make notification channel headings clickable in notification #983

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

ayesha-waris
Copy link
Contributor

@ayesha-waris ayesha-waris commented Jan 25, 2024

INF-1062

Explanation:

The code for the notification channel headings has been made more generic. An on-click event handler has been implemented along with relevant updates in the selectors, thunk, and service files needed for it.

The implementation for the new back-end API can be found in PR

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (0ee0f41) 56.50% compared to head (6573b59) 56.53%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/notification-preferences/data/thunks.js 28.57% 5 Missing ⚠️
src/notification-preferences/data/service.js 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   56.50%   56.53%   +0.02%     
==========================================
  Files         118      118              
  Lines        2435     2457      +22     
  Branches      652      654       +2     
==========================================
+ Hits         1376     1389      +13     
- Misses        988      997       +9     
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for this change other than this PR LGTM.

@ayesha-waris ayesha-waris merged commit 3467534 into master Feb 7, 2024
9 checks passed
@ayesha-waris ayesha-waris deleted the eemaanamir/INF-1062 branch February 7, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants