feat: add toggling for the hardcode support link (for master) #864
Conversation
|
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
mphilbrick211
added
the
needs test run
Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting.
DmytroAlipov
force-pushed
the
feat-unlink-social-media-account
branch
from
09b1967 to
979c13c
Compare
|
@DmytroAlipov Looks like there are some linting failures, https://github.com/openedx/frontend-app-account/actions/runs/6048702918/job/16519629022?pr=864#step:7:20, Can you have a look? |
e0d
added
waiting on author
Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting.
…account' into feat-unlink-social-media-account
|
@e0d done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 46.54% 46.63% +0.08%
==========================================
Files 122 122
Lines 2548 2552 +4
Branches 669 672 +3
==========================================
+ Hits 1186 1190 +4
Misses 1286 1286
Partials 76 76
☔ View full report in Codecov by Sentry. |
mphilbrick211
removed
the
waiting on author
|
Hi @openedx/fed-bom! Would someone be able to please review/merge this for us? Thanks! |
abdullahwaheed
requested review from
abdullahwaheed
and removed request for
abdullahwaheed
|
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
…x#864) * feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. * fix(deps): update dependency @edx/frontend-platform to v5.3.0 * Revert "fix(deps): update dependency @edx/frontend-platform to v5.3.0" (openedx#870) This reverts commit 757e446. * feat: add toggling for the hardcode support link (master) Add a toggling mechanism for the "unlink all social media accounts" text to show it as a link or text depending on the MFE env setting. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Muhammad Abdullah Waheed <[email protected]>
Description:
Add a toggling mechanism for the
unlink all social media accountstext to display it as a link or text depending on the MFE env setting.Currently, the link leads to the page https://support.edx.org/hc/en-us/articles/207206067 which is hardcoded. I suggest adding the
DISABLE_UNLINK_SOCIAL_MEDIA_ACCOUNT_SUPPORT_URLvariable to control whether this text is displayed as a link or as plain text.Before:
After:
