Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete my account" is not updated when changing the language #622

Closed
mrtndwrd opened this issue Aug 15, 2022 · 5 comments
Closed

"Delete my account" is not updated when changing the language #622

mrtndwrd opened this issue Aug 15, 2022 · 5 comments

Comments

@mrtndwrd
Copy link

Steps to reproduce (on https://apps.demo.openedx.overhang.io/, I assume they run the newest version of the MFE to date):

  1. Create an account and log in
  2. Go to /account
  3. Change the language, for example to Spanish

Expected result:

The whole page is shown in the new language

Actual result:

The page is shown in the new language, but the "Delete my account" section is still in English

image

When I refresh, the page is fully in English, so it's not a missing translation.

@heldersepu
Copy link
Contributor

Seem to be working fine now:
https://apps.demo.openedx.overhang.io/account/#delete-account

image

@heldersepu
Copy link
Contributor

From a code perspective it seems that code/translation has been there for a while:
https://github.com/openedx/frontend-app-account/blame/open-release/palm.master/src/i18n/messages/es_419.json#L141

Maybe it was a hiccup?!?
I'm not able to reproduce

@mrtndwrd
Copy link
Author

I don't think it was a hiccup, because I had this problem consistently on different environments. I don't work on that project anymore though, so I can't tell you if the problem is fixed or not. I can imagine some seemingly unrelated change fixed it, so if you can't reproduce it, feel free to close this issue.

@mrtndwrd
Copy link
Author

I think i made a mistake with the original message by the way:

When I refresh, the page is fully in English, so it's not a missing translation.

Should have been "... fully in Spanish".

The point being that the text is only wrong after you've changed the language and have not refreshed the page yet. So yes, the translation was always there, but it wasn't used correctly after changing the language.

@mrtndwrd
Copy link
Author

OK sorry for posting so many times. I just checked on the original link and it seems like the issue is indeed resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants