-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: send json accept headers for POST requests #1139
fix: send json accept headers for POST requests #1139
Conversation
Thanks for the pull request, @BryanttV! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi! @mariajgrimaldi @arbrandes, here is the solution to correct the CORS error. I look forward to any questions or comments. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
- Coverage 58.61% 58.53% -0.08%
==========================================
Files 117 117
Lines 2317 2320 +3
Branches 644 641 -3
==========================================
Hits 1358 1358
- Misses 898 901 +3
Partials 61 61 ☔ View full report in Codecov by Sentry. |
Hi @mariajgrimaldi @arbrandes, Although this change fixes the CORS error, according to the tests I did locally the language is still not being changed until the page is reloaded. |
Hi, @mariajgrimaldi @arbrandes. I did another test using a tutor plugin instead of a mount. Now, it updates the language without reloading the page. I'm not sure why the mount doesn't work. account-mfe-1139.mp4I switched to each language and as reported in the issue, some don't work.
None of the 4 failing ones is here. |
Great news, @BryanttV! Thank you so much for testing this out. I'll try to get someone to review this :) |
Starting to review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this, and it works! Thank you!
…ccept fix: send json accept headers for POST requests
Description
This PR solves a CORS error when calling the endpoints for Changing Site Language and Unlinking the SSO Account. To resolve this error we simply specify the
Accept: 'application/json'
header in the request.These are the related issues:
Testing Instructions
The changes have been tested in a local environment with Tutor v18.1.3.
tutor mounts add frontend-app-account
tutor dev start -d
to recreate the containers.npm install
tutor dev restart
Changing Site Language
Unlinking the SSO Account
Screenshots
Merge Checklist
Post-merge Checklist