Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rebase 2u-main with master #1134

Closed
wants to merge 2 commits into from

Conversation

awais-ansari
Copy link
Contributor

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

awais-ansari and others added 2 commits October 1, 2024 22:11
* feat: added country disabling feature

* refactor: removed isDisabledCountry additional call
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.70%. Comparing base (c31e164) to head (dbb3748).

Files with missing lines Patch % Lines
src/account-settings/AccountSettingsPage.jsx 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1134      +/-   ##
==========================================
+ Coverage   58.61%   58.70%   +0.09%     
==========================================
  Files         117      117              
  Lines        2317     2332      +15     
  Branches      641      648       +7     
==========================================
+ Hits         1358     1369      +11     
- Misses        898      902       +4     
  Partials       61       61              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@awais-ansari awais-ansari deleted the aansari/rebase-with-master branch October 10, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant