Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade to Node 20 #1090

Merged
merged 8 commits into from
Aug 29, 2024
Merged

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 25, 2024

Description

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

Second step in the Node 20 upgrade process, See the tracking issue for futher information.

@BilalQamar95 BilalQamar95 self-assigned this Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.61%. Comparing base (70fc2f9) to head (bf8a817).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   58.61%   58.61%           
=======================================
  Files         117      117           
  Lines        2317     2317           
  Branches      639      639           
=======================================
  Hits         1358     1358           
  Misses        898      898           
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 marked this pull request as draft July 25, 2024 12:54
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 5, 2024 11:44
@BilalQamar95 BilalQamar95 marked this pull request as draft August 5, 2024 12:02
@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/node-v20-upgrade branch from 46ffce6 to e08f5c4 Compare August 5, 2024 13:42
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 8, 2024 10:42
@BilalQamar95 BilalQamar95 marked this pull request as draft August 21, 2024 08:40
@BilalQamar95
Copy link
Contributor Author

BilalQamar95 commented Aug 21, 2024

PR will be updated and ready for review once the prerequisite PR for step 1 of the node v20 upgrade process is reviewed/merged.

@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 21, 2024
@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 23, 2024 11:12
@BilalQamar95 BilalQamar95 mentioned this pull request Aug 23, 2024
@brian-smith-tcril brian-smith-tcril merged commit 14f1cfd into master Aug 29, 2024
11 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node-v20-upgrade branch August 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants