Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enmerkar-underscore on Python 3.11 #149

Closed
6 tasks done
Tracked by #34229
feanil opened this issue Mar 25, 2024 · 4 comments · Fixed by #156 or openedx/edx-platform#34660
Closed
6 tasks done
Tracked by #34229

Test enmerkar-underscore on Python 3.11 #149

feanil opened this issue Mar 25, 2024 · 4 comments · Fixed by #156 or openedx/edx-platform#34660
Assignees

Comments

@feanil
Copy link

feanil commented Mar 25, 2024

This repository is a depedency of edx-platform and needs to be upgraded to Python 3.11 before
the Readwood release is cut (mid-April).

  • Requirements are compiled with Python 3.8
  • Tests are run on Python 3.8 and 3.11
  • (Optional) Tests are also run with 3.12 and passing or 3.12 issues are ticketed.
  • Classifiers in setup.py setup.cfg or pyproject.toml indicate Python 3.11 support
  • A new version is release to PyPI
  • A PR is merged to edx-platform to use the new version
@feanil
Copy link
Author

feanil commented Apr 20, 2024

Looks like this one is a bit complicated, it depends on an old version of markey which has a regex that isn't valid in Python 3.11/3.12 so we'll probably need to fork that and update this library to use a corrected version.

@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented Apr 25, 2024

Here's is the latest commit made to conf/locale/babel_underscore.cfg, where this library is used -- it was the only reference I could find in edx-platform. The commit was made by @awais786 4 years ago. Do you know if this library is still used in the translation process?

@mariajgrimaldi mariajgrimaldi removed their assignment Apr 25, 2024
@mariajgrimaldi
Copy link
Member

I unassigned myself since @feanil is already working on fixing the issue with the unmaintained requirement. Thank you!

@feanil feanil self-assigned this Apr 26, 2024
@feanil
Copy link
Author

feanil commented Apr 26, 2024

I took a quick look and it looks like we do still need this extractor because of all the underscore templates that still exist in edx-platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants