Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ai translations as a translation provider #544

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jansenk
Copy link

@jansenk jansenk commented Nov 27, 2024

Added edx_ai_translations as a transcript provider option

I didn't want it to also be an option for TranscriptPreference.provider or ThirdPartyTranscriptCredentialsState.provier at this point .... potentially in the future?

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (189ec0a) to head (33a3c71).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   94.56%   94.57%   +0.01%     
==========================================
  Files          31       32       +1     
  Lines        3165     3171       +6     
  Branches      122      122              
==========================================
+ Hits         2993     2999       +6     
  Misses        154      154              
  Partials       18       18              
Flag Coverage Δ
unittests 94.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BrandonHBodine BrandonHBodine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work without updating the line at

if provider and provider not in list(dict(TranscriptProviderType.CHOICES).keys()):


CHOICES = (
(CUSTOM, CUSTOM),
(THREE_PLAY_MEDIA, THREE_PLAY_MEDIA),
(CIELO24, CIELO24),
)

# Choices specififcally for only the VideoTranscript model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the CHOICES enumeration already isolated to the VideoTranscript model?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TranscriptPreference and ThirdPartyTranscriptCredentialsState also use this model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants