Python Requirements Update #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
List of packages in the PR without any issue.
|
|
These Packages need manual review..
|
MichaelRoytman
force-pushed
the
jenkins/upgrade-python-requirements-7515121
branch
2 times, most recently
from
4413461 to
faac27e
Compare
The tox quality environment is used to run quality tests (i.e. pylint, pycodestyle, and isort) on the codebase. This environment installs dependencies from both the test and quality requirement files. This has caused a dependency resolution error with the importlib-metadata dependency. In the test requirements, importlib-metadata is a dependency of the logilab-common dependency, and this installs importlib-metadata=6.11.0. In the quality requirements, importlib-metadata is a dependency of the rstcheck and rstcheck-core dependencies, and this installs importlib-metadata=7.0.1. This causes a dependency resolution conflict when running the tox quality environment, because both the test and quality requirements files are installed in this environment, and versions 6.11.0 and 7.0.1 of importlib-metadata are requested, respectively. The simplest solution is to remove the logilab-common dependency from the test requirements file, as it has no obvious purpose, particularly since this project does not explicitly install importlib-metadata and logilab-common, rstcheck, and rstcheck-core have very loose requirements ranges. This means we cannot easily ensure that the two importlib-metadata package versions match by modifying our versions of logilab-common, rstcheck, or rstcheck-core. It was also not possible to remove the test requirements from the tox quality environment, because then the quality checks fail with import errors for modules used in the tests (e.g. mock).
MichaelRoytman
force-pushed
the
jenkins/upgrade-python-requirements-7515121
branch
from
faac27e to
6492a59
Compare
zacharis278
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requirements update. Please review the changelogs for the upgraded packages.
NOTE: This pull request also includes the changes described below.
The tox quality environment is used to run quality tests (i.e.
pylint,pycodestyle, andisort) on the codebase. This environment installs dependencies from both the test and quality requirement files.This has caused a dependency resolution error with the
importlib-metadatadependency. In the test requirements,importlib-metadatais a dependency of thelogilab-commondependency, and this installsimportlib-metadata=6.11.0. In the quality requirements,importlib-metadatais a dependency of therstcheckandrstcheck-coredependencies, and this installsimportlib-metadata=7.0.1. This causes a dependency resolution conflict when running the tox quality environment, because both the test and quality requirements files are installed in this environment, and versions6.11.0and7.0.1ofimportlib-metadataare requested, respectively.The simplest solution is to remove the
logilab-commondependency from the test requirements file, as it has no obvious purpose, particularly since this project does not explicitly installimportlib-metadataandlogilab-common,rstcheck, andrstcheck-corehave very loose requirements ranges. This means we cannot easily ensure that the twoimportlib-metadatapackage versions match by modifying our versions oflogilab-common,rstcheck, orrstcheck-core. It was also not possible to remove the test requirements from the tox quality environment, because then the quality checks fail with import errors for modules used in the tests (e.g.mock).Deleted obsolete pull_requests:
#1174