Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade to Node 20 #35342

Merged
merged 3 commits into from
Dec 5, 2024
Merged

build: Upgrade to Node 20 #35342

merged 3 commits into from
Dec 5, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Aug 22, 2024 •
edited
Loading

Description

Part of openedx/public-engineering#230

  • Regenerated package-lock.json with node v20 and NPM 10.
  • Updated .nvmrc to v20
  • Updated the lockfile version check workflow

@BilalQamar95 BilalQamar95 marked this pull request as ready for review August 27, 2024 10:22
@BilalQamar95 BilalQamar95 changed the title feat: updated node to v20 build: Upgrade to Node 20 Aug 27, 2024
@BilalQamar95 BilalQamar95 self-assigned this Aug 27, 2024
feanil
feanil requested changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BilalQamar95 we should not merge this until after this deadline: #35015

2U should be able to move to node 20 today as we're already testing with that so if there are issues with that, those should be raised separately.

@feanil
Copy link
Contributor

feanil commented Nov 7, 2024

@BilalQamar95 has 2U moved to Node 20 for their deployment of edx-platform?

@BilalQamar95
Copy link
Contributor Author

@BilalQamar95 has 2U moved to Node 20 for their deployment of edx-platform?

I don't think they have

feanil
feanil approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deadline for this update has arrived, this is good to merge now.

@feanil feanil force-pushed the bilalqamar95/upgrade-node-v20 branch from 839418c to 85a891a Compare December 5, 2024 16:21
@feanil feanil merged commit 60aa299 into master Dec 5, 2024
49 checks passed
@feanil feanil deleted the bilalqamar95/upgrade-node-v20 branch December 5, 2024 17:59
This was referenced Dec 5, 2024
Closed
Closed
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees

@BilalQamar95 BilalQamar95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BilalQamar95 @feanil @edx-pipeline-bot