Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove paver update_db task #32828

Closed

Conversation

solababs
Copy link
Contributor

@solababs solababs commented Jul 24, 2023

Description

As part of the effort to deprecate paver overall hence the update_db task is being removed here.
This change would break any references to the paver update_db task.
Effort has been made to remove all refrences that can be found in other repos and would be linked to this PR appropiately.
Additional work to convert to an alternative make migrate has been done as part of openedx-unsupported/devstack#1085 and any left over work would be done and linked to this PR appropiately.

Supporting information

This PR fixes #32683 and #32252

Testing instructions

Before this change, you could run paver update_db in the lms.
After this change, on running paver update_db you should get an error message like Build failed: Unknown task: update_db
There are no references to this task in the docs.

Fixes: #32683 and #32252
Private-ref: https://tasks.opencraft.com/browse/BB-7705

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 24, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 24, 2023

Thanks for the pull request, @solababs! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 25, 2023
@solababs solababs changed the title depr: remove paver update_db task refactor: remove paver update_db task Jul 25, 2023
@solababs solababs changed the title refactor: remove paver update_db task refactor: remove paver update_db task Jul 25, 2023
@solababs solababs changed the title refactor: remove paver update_db task refactor: remove paver update_db task Jul 25, 2023
@solababs solababs marked this pull request as ready for review July 26, 2023 07:10
@solababs solababs changed the title refactor: remove paver update_db task refactor: remove paver update_db task Jul 27, 2023
@solababs solababs changed the title refactor: remove paver update_db task refactor: remove paver update_db task Jul 27, 2023
@solababs solababs changed the title refactor: remove paver update_db task chore: remove paver update_db task Jul 28, 2023
@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jul 28, 2023
@e0d
Copy link
Contributor

e0d commented Jul 28, 2023

Hi @solababs , I notice there are some commit-lint failures. Please note that we use conventional commits across Open edX projects. You can read about the details here. Can you please amend your commit messages to follow our standard?

There also seem to be some unit test failure. Can you have a look at those as well?

@solababs solababs closed this Jul 30, 2023
@solababs solababs force-pushed the solababs/remove-paver-update-db branch from fd13037 to b94b0a8 Compare July 30, 2023 16:11
@solababs
Copy link
Contributor Author

Closing this PR as same work has been done here #32832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[DEPR]: paver update_db
4 participants