feat: Add migrate Make command. #32705
Conversation
There was a problem hiding this comment.
Thanks.
- Are there any docs where this is needed? I guess most of the Makefile commands are called from somewhere, like the provisioning scripts, and those are documented.
[idea] Could we have a migrate-lms, migrate-cms, and migrate command which calls the former two? Then, could the provisioning script call these Makefile commands? I'm not sure if that is better, but I imagine that the provisioning scripts for the other services just call make migrate, so this would be more consistent. Thoughts?
- Does
.PHONYneed to be updated?
dianakhuang
force-pushed
the
diana/add-migrate-command
branch
2 times, most recently
from
5b5c871 to
e253024
Compare
|
@robrap made this more in line with the devstack Make command and it should be ready for rereview. |
There was a problem hiding this comment.
Minor fix for .PHONY and looks good.
Regarding the devstack Makefile (non-blocking for this PR):
- Should we update to call this script?
- Is there a reason that devstack calls
showmigrationsfor cms and lms, but not for other IDAs. Should that just be dropped? What's its purpose?
dianakhuang
force-pushed
the
diana/add-migrate-command
branch
from
e253024 to
d461c4a
Compare
To make edx-platform more consistent with other IDAs and to help deprecate more of paver, we are adding the ability to run `make migrate` in a local environment as a replacement for `paver update_db`. openedx-unsupported/devstack#1085
dianakhuang
force-pushed
the
diana/add-migrate-command
branch
from
d461c4a to
93da3d8
Compare
|
Yeah, I was planning on moving the devstack code over to use this Make target instead. I think including |
Options are:
I do not feel strongly, and probably would have chosen option 1, but am curious if you think it is a convenience worth keeping, why you would want that in devstack, but not in edx-platform directly (option 4)? |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
To make edx-platform more consistent with other IDAs and to help deprecate more of paver, we are adding the ability to run
make migratein a local environment as a replacement forpaver update_db.openedx-unsupported/devstack#1085