You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ADR 14 is a decision to require justification for the addition of any new app to edx-platform. However, it has proven difficult to socialize this decision well enough that people abide by it; usually they find out once it's in production and Arch-BOM comes asking about it (having learned of the app via instrumentation). We could have those discussions much sooner if we add GitHub Actions to check for new apps.
Acceptance criteria:
GitHub Action that fails if a new Django app is added that does not contain an ADR (details in OEP-49 shortly)
Trigger on PRs
Detect whether new directories have been added under the known Django apps directories, and check them
GitHub Action failure has an informative message that points to the ADR (use a job summary)
Optional: Consider making a reusable action that can be pointed at any directory and that checks as much of OEP-49 as possible; then use that from edx-platform
The text was updated successfully, but these errors were encountered:
ADR 14 is a decision to require justification for the addition of any new app to edx-platform. However, it has proven difficult to socialize this decision well enough that people abide by it; usually they find out once it's in production and Arch-BOM comes asking about it (having learned of the app via instrumentation). We could have those discussions much sooner if we add GitHub Actions to check for new apps.
Acceptance criteria:
The text was updated successfully, but these errors were encountered: