-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up PII annotations #2293
base: master
Are you sure you want to change the base?
Conversation
moodle.HistoricalMoodleEnterpriseCustomerConfiguration: | ||
".. no_pii:": "" | ||
enterprise.EnterpriseCourseEntitlement: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this one and the next are necessary here, I annotated them on the models, but if we need them here let me know so I can comment why.
bdcff66
to
1ded57a
Compare
Adding some missing annotations, fixing typo'd annotation, removing what seem like unnecessary annotations from the safe list. This work is in preparation for getting the annotation checker running on edx-platform again.
1ded57a
to
9f8dcda
Compare
Hey @pwnage101 ! It looks like you were the last one to touch this stuff, do you think you could review this or point me to someone who could? |
Not sure who might be able to review here, @adamstankiewicz could you maybe point me in the right direction? |
Thanks for the PR Bmez |
Adding some missing annotations, fixing typo'd annotation, removing what seem like unnecessary annotations from the safe list. This work is in preparation for getting the annotation checker running on edx-platform again. I don't think this work should merit a version bump or release, it's just changes to comments and the safe list.
Merge checklist:
requirements/*.txt
files)base.in
if needed in production but edx-platform doesn't install ittest-master.in
if edx-platform pins it, with a matching versionmake upgrade && make requirements
have been run to regenerate requirementsmake static
has been run to update webpack bundling if any static content was updated./manage.py makemigrations
has been run./manage.py lms makemigrations
in the shell.Post merge:
(so basically once your build finishes, after maybe a minute you should see the new version in PyPi automatically (on refresh))
make upgrade
in edx-platform will look for the latest version in PyPi.